From 53efb429e3143fb749a1ed62e316ddb081e20d42 Mon Sep 17 00:00:00 2001
From: Staf Wagemakers <staf@wagemakers.be>
Date: Sun, 16 Aug 2020 10:03:10 +0200
Subject: [PATCH] moved raspberry specific settings to raspberrypi role

---
 .../handlers/main.yml                         |  0
 roles/raspberrypi/tasks/main.yml              | 48 +++++++++++++++++++
 .../tasks/prereq/Raspbian.yml}                | 14 ------
 .../tasks/prereq/Ubuntu.yml}                  |  0
 roles/raspberrypi/tasks/prereq/default.yml    |  1 +
 site.yml                                      |  3 +-
 6 files changed, 50 insertions(+), 16 deletions(-)
 rename roles/{raspbian => raspberrypi}/handlers/main.yml (100%)
 create mode 100644 roles/raspberrypi/tasks/main.yml
 rename roles/{raspbian/tasks/main.yml => raspberrypi/tasks/prereq/Raspbian.yml} (57%)
 rename roles/{ubuntu/tasks/main.yml => raspberrypi/tasks/prereq/Ubuntu.yml} (100%)
 create mode 100644 roles/raspberrypi/tasks/prereq/default.yml

diff --git a/roles/raspbian/handlers/main.yml b/roles/raspberrypi/handlers/main.yml
similarity index 100%
rename from roles/raspbian/handlers/main.yml
rename to roles/raspberrypi/handlers/main.yml
diff --git a/roles/raspberrypi/tasks/main.yml b/roles/raspberrypi/tasks/main.yml
new file mode 100644
index 0000000..5979631
--- /dev/null
+++ b/roles/raspberrypi/tasks/main.yml
@@ -0,0 +1,48 @@
+---
+- name: Test for raspberry pi /proc/cpuinfo
+  command: grep -E "Raspberry Pi|BCM2708|BCM2709|BCM2835|BCM2836" /proc/cpuinfo
+  register: grep_cpuinfo_raspberrypi
+  failed_when: false
+  changed_when: false
+
+- name: Test for raspberry pi /proc/device-tree/model
+  command: grep -E "Raspberry Pi" /proc/device-tree/model
+  register: grep_device_tree_model_raspberrypi
+  failed_when: false
+  changed_when: false
+
+- name: Set raspberry_pi fact to true
+  set_fact:
+    raspberry_pi: true
+  when:
+    grep_cpuinfo_raspberrypi.rc == 0 or grep_device_tree_model_raspberrypi.rc == 0
+
+- name: Set detected_distribution to Raspbian
+  set_fact:
+    detected_distribution: Raspbian
+  when:
+   - raspberry_pi|default(false)
+   - ansible_facts.lsb.id|default("") == "Raspbian" or ansible_facts.lsb.description|default("") is match("[Rr]aspbian.*")
+
+- name: Set detected_distribution to Raspbian (ARM64 on Debian Buster)
+  set_fact:
+    detected_distribution: Raspbian
+  when:
+    - ansible_facts.architecture is search("aarch64")
+    - raspberry_pi|default(false)
+    - ansible_facts.lsb.description|default("") is match("Debian.*buster")
+
+- name: Set detected_distribution_major_version
+  set_fact:
+    detected_distribution_major_version: "{{ ansible_facts.lsb.major_release }}"
+  when:
+    - detected_distribution | default("") == "Raspbian"
+
+- name: execute OS related tasks on the Raspberry Pi
+  include_tasks: "{{ item }}"
+  with_first_found:
+    - "prereq/{{ detected_distribution }}-{{ detected_distribution_major_version }}.yml"
+    - "prereq/{{ detected_distribution }}.yml"
+    - "prereq/{{ ansible_distribution }}-{{ ansible_distribution_major_version }}.yml"
+    - "prereq/{{ ansible_distribution }}.yml"
+    - "prereq/default.yml"
diff --git a/roles/raspbian/tasks/main.yml b/roles/raspberrypi/tasks/prereq/Raspbian.yml
similarity index 57%
rename from roles/raspbian/tasks/main.yml
rename to roles/raspberrypi/tasks/prereq/Raspbian.yml
index 04c931a..42bfe7d 100644
--- a/roles/raspbian/tasks/main.yml
+++ b/roles/raspberrypi/tasks/prereq/Raspbian.yml
@@ -1,13 +1,4 @@
 ---
-- name: Test for Raspbian
-  set_fact:
-    raspbian: '{% if
-      ( ansible_facts.architecture is search("arm") and
-        ansible_facts.lsb.description is match("[Rr]aspbian.*[Bb]uster") ) or
-      ( ansible_facts.architecture is search("aarch64") and
-        ansible_facts.lsb.description is match("Debian.*buster") or
-        ansible_facts.lsb.description is match("[Rr]aspbian.*[Bb]uster") ) %}true{% else %}false{% endif %}'
-
 - name: Activating cgroup support
   lineinfile:
     path: /boot/cmdline.txt
@@ -15,13 +6,10 @@
     line: '\1 cgroup_enable=cpuset cgroup_memory=1 cgroup_enable=memory'
     backrefs: true
   notify: reboot
-  when:
-    - raspbian is true
 
 - name: Flush iptables before changing to iptables-legacy
   iptables:
     flush: true
-  when: raspbian
   changed_when: false   # iptables flush always returns changed
 
 - name: Changing to iptables-legacy
@@ -29,11 +17,9 @@
     path: /usr/sbin/iptables-legacy
     name: iptables
   register: ip4_legacy
-  when: raspbian
 
 - name: Changing to ip6tables-legacy
   alternatives:
     path: /usr/sbin/ip6tables-legacy
     name: ip6tables
   register: ip6_legacy
-  when: raspbian
diff --git a/roles/ubuntu/tasks/main.yml b/roles/raspberrypi/tasks/prereq/Ubuntu.yml
similarity index 100%
rename from roles/ubuntu/tasks/main.yml
rename to roles/raspberrypi/tasks/prereq/Ubuntu.yml
diff --git a/roles/raspberrypi/tasks/prereq/default.yml b/roles/raspberrypi/tasks/prereq/default.yml
new file mode 100644
index 0000000..ed97d53
--- /dev/null
+++ b/roles/raspberrypi/tasks/prereq/default.yml
@@ -0,0 +1 @@
+---
diff --git a/site.yml b/site.yml
index 8862e96..31cc96e 100644
--- a/site.yml
+++ b/site.yml
@@ -6,8 +6,7 @@
   roles:
     - role: prereq
     - role: download
-    - role: raspbian
-    - role: ubuntu
+    - role: raspberrypi
 
 - hosts: master
   become: yes