fix: typos (#416)

Co-authored-by: Techno Tim <timothystewart6@gmail.com>

.github/workflows/cache.yml

@@ -5,7 +5,7 @@ on:
 jobs:
   molecule:
     name: cache
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     env:
       PYTHON_VERSION: "3.11"
 
@@ -21,32 +21,6 @@ jobs:
           python-version: ${{ env.PYTHON_VERSION }}
           cache: 'pip' # caching pip dependencies
 
-      # - name: Cache Ansible
-      #   uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # 4.0
-      #   id: cache-ansible
-      #   with:
-      #     path: ~/.ansible/collections
-      #     key: ansible-${{ hashFiles('collections/requirements.yml') }}
-      #     restore-keys: |
-      #       ansible-
-
-      - name: Install dependencies
-        run: |
-          echo "::group::Upgrade pip"
-          python3 -m pip install --upgrade pip
-          echo "::endgroup::"
-
-          echo "::group::Install Python requirements from requirements.txt"
-          python3 -m pip install -r requirements.txt
-          echo "::endgroup::"
-
-      # - name: Install ansible dependencies
-      #   if: steps.cache-ansible.outputs.cache-hit != 'true' # only run if false since this is just a cache step
-      #   run: |
-      #     echo "::group::Install Ansible role requirements from collections/requirements.yml"
-      #     ansible-galaxy install -r collections/requirements.yml
-      #     echo "::endgroup::"
-
       - name: Cache Vagrant boxes
         id: cache-vagrant
         uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # 4.0
@@ -58,36 +32,6 @@ jobs:
           restore-keys: |
             vagrant-boxes
 
-      - name: install apt packages
-        run: |
-          wget -O- https://apt.releases.hashicorp.com/gpg | sudo gpg --dearmor -o /usr/share/keyrings/hashicorp-archive-keyring.gpg
-          echo "deb [signed-by=/usr/share/keyrings/hashicorp-archive-keyring.gpg] https://apt.releases.hashicorp.com $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/hashicorp.list
-          sudo apt update && sudo apt -y install vagrant virtualbox
-
-
-      # - name: Configure Homebrew cache
-      #   uses: actions/cache@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # 4.0
-      #   id: cache-homebrew
-      #   with:
-      #     path: |
-      #       ~/Library/Caches/Homebrew
-      #     key: brew-${{ hashFiles('./Brewfile') }}
-      #     restore-keys: brew-
-
-      # - name: Update Homebrew
-      #   if: | # only run if false since this is just a cache step
-      #     steps.cache-homebrew.outputs.cache-hit != 'true' || steps.cache-vagrant.outputs.cache-hit != 'true'
-      #   run: |
-      #     brew update --preinstall
-
-      # - name: Install Homebrew dependencies
-      #   if: | # only run if false since this is just a cache step
-      #     steps.cache-homebrew.outputs.cache-hit != 'true' || steps.cache-cache-vagrant.outputs.cache-hit != 'true'
-      #   run: |
-      #     env HOMEBREW_NO_AUTO_UPDATE=1 brew bundle --no-upgrade  --file ./Brewfile
-      #     vagrant --version
-      #     vboxmanage --version
-
       - name: Download Vagrant boxes for all scenarios
         # To save some cache space, all scenarios share the same cache key.
         # On the other hand, this means that the cache contents should be

.github/workflows/lint.yml

@@ -5,7 +5,7 @@ on:
 jobs:
   pre-commit-ci:
     name: Pre-Commit
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     env:
       PYTHON_VERSION: "3.11"
 
@@ -42,7 +42,7 @@ jobs:
 
   ensure-pinned-actions:
     name: Ensure SHA Pinned Actions
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     steps:
       - name: Checkout code
         uses: actions/checkout@e2f20e631ae6d7dd3b768f56a5d2af784dd54791 # v3 2.5.0

.github/workflows/test.yml

@@ -5,7 +5,7 @@ on:
 jobs:
   molecule:
     name: Molecule
-    runs-on: ubuntu-latest
+    runs-on: self-hosted
     strategy:
       matrix:
         scenario:
@@ -22,11 +22,6 @@ jobs:
         with:
           ref: ${{ github.event.pull_request.head.sha }}
 
-      # - name: Restore Ansible cache
-      #   uses: actions/cache/restore@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # 4.0
-      #   with:
-      #     path: ~/.ansible/collections
-      #     key: ansible-${{ hashFiles('collections/requirements.yml') }}
       - name: Configure VirtualBox
         run: |-
           sudo mkdir -p /etc/vbox
@@ -41,29 +36,6 @@ jobs:
           python-version: ${{ env.PYTHON_VERSION }}
           cache: 'pip' # caching pip dependencies
 
-      # - name: Restore Homebrew cache
-      #   uses: actions/cache/restore@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # 4.0
-      #   with:
-      #     path: |
-      #       ~/Library/Caches/Homebrew
-      #     key: brew-${{ hashFiles('./Brewfile') }}
-
-      # - name: Update Homebrew
-      #   run: |
-      #     brew update --preinstall
-
-      # - name: Install Homebrew dependencies
-      #   run: |
-      #     env HOMEBREW_NO_AUTO_UPDATE=1 brew bundle --no-upgrade  --file ./Brewfile
-      #     vagrant --version
-      #     vboxmanage --version
-
-      - name: install apt packages
-        run: |
-          wget -O- https://apt.releases.hashicorp.com/gpg | sudo gpg --dearmor -o /usr/share/keyrings/hashicorp-archive-keyring.gpg
-          echo "deb [signed-by=/usr/share/keyrings/hashicorp-archive-keyring.gpg] https://apt.releases.hashicorp.com $(lsb_release -cs) main" | sudo tee /etc/apt/sources.list.d/hashicorp.list
-          sudo apt update && sudo apt -y install vagrant virtualbox
-
       - name: Restore vagrant Boxes cache
         uses: actions/cache/restore@13aacd865c20de90d75de3b17ebe84f7a17d57d2 # 4.0
         with:

Brewfile

@@ -1,5 +0,0 @@
-tap "homebrew/bundle"
-tap "hashicorp/tap"
-
-cask "virtualbox"
-cask "vagrant"

inventory/sample/group_vars/all.yml

@@ -66,9 +66,9 @@ metal_lb_ip_range: "192.168.30.80-192.168.30.90"
 # Please read https://gist.github.com/triangletodd/02f595cd4c0dc9aac5f7763ca2264185 before using this.
 # Most notably, your containers must be privileged, and must not have nesting set to true.
 # Please note this script disables most of the security of lxc containers, with the trade off being that lxc
-# containers are significantly more resource efficent compared to full VMs.
+# containers are significantly more resource efficient compared to full VMs.
 # Mixing and matching VMs and lxc containers is not supported, ymmv if you want to do this.
-# I would only really recommend using this if you have partiularly low powered proxmox nodes where the overhead of
+# I would only really recommend using this if you have particularly low powered proxmox nodes where the overhead of
 # VMs would use a significant portion of your available resources.
 proxmox_lxc_configure: false
 # the user that you would use to ssh into the host, for example if you run ssh some-user@my-proxmox-host,

molecule/default/molecule.yml

@@ -1,16 +1,14 @@
 ---
 dependency:
   name: galaxy
-  options:
-    requirements-file: collections/requirements.yml
 driver:
   name: vagrant
 platforms:
 
   - name: control1
     box: generic/ubuntu2204
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - master
@@ -25,8 +23,8 @@ platforms:
 
   - name: control2
     box: generic/debian11
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - master
@@ -36,8 +34,8 @@ platforms:
 
   - name: control3
     box: generic/rocky9
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - master
@@ -47,8 +45,8 @@ platforms:
 
   - name: node1
     box: generic/ubuntu2204
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - node
@@ -63,8 +61,8 @@ platforms:
 
   - name: node2
     box: generic/rocky9
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - node
@@ -75,7 +73,7 @@ platforms:
 provisioner:
   name: ansible
   env:
-    ANSIBLE_VERBOSITY: 3
+    ANSIBLE_VERBOSITY: 1
   playbooks:
     converge: ../resources/converge.yml
     side_effect: ../resources/reset.yml

molecule/ipv6/molecule.yml

@@ -1,15 +1,13 @@
 ---
 dependency:
   name: galaxy
-  options:
-    requirements-file: collections/requirements.yml
 driver:
   name: vagrant
 platforms:
   - name: control1
     box: generic/ubuntu2204
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - master
@@ -24,8 +22,8 @@ platforms:
 
   - name: control2
     box: generic/ubuntu2204
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - master
@@ -40,8 +38,8 @@ platforms:
 
   - name: node1
     box: generic/ubuntu2204
-    memory: 512
+    memory: 1024
-    cpus: 1
+    cpus: 2
     groups:
       - k3s_cluster
       - node
@@ -56,7 +54,7 @@ platforms:
 provisioner:
   name: ansible
   env:
-    ANSIBLE_VERBOSITY: 3
+    ANSIBLE_VERBOSITY: 1
   playbooks:
     converge: ../resources/converge.yml
     side_effect: ../resources/reset.yml

molecule/single_node/molecule.yml

@@ -1,15 +1,13 @@
 ---
 dependency:
   name: galaxy
-  options:
-    requirements-file: collections/requirements.yml
 driver:
   name: vagrant
 platforms:
   - name: control1
     box: generic/ubuntu2204
-    memory: 512
+    memory: 4096
-    cpus: 1
+    cpus: 4
     config_options:
       # We currently can not use public-key based authentication on Ubuntu 22.04,
       # see: https://github.com/chef/bento/issues/1405
@@ -24,7 +22,7 @@ platforms:
 provisioner:
   name: ansible
   env:
-    ANSIBLE_VERBOSITY: 3
+    ANSIBLE_VERBOSITY: 1
   playbooks:
     converge: ../resources/converge.yml
     side_effect: ../resources/reset.yml

roles/k3s_agent/tasks/http_proxy.yml

@@ -1,8 +1,8 @@
 ---
 
-- name: Create k3s.service.d directory
+- name: Create k3s-node.service.d directory
   file:
-    path: '{{ systemd_dir }}/k3s.service.d'
+    path: '{{ systemd_dir }}/k3s-node.service.d'
     state: directory
     owner: root
     group: root
@@ -12,7 +12,7 @@
 - name: Copy K3s http_proxy conf file
   template:
     src: "http_proxy.conf.j2"
-    dest: "{{ systemd_dir }}/k3s.service.d/http_proxy.conf"
+    dest: "{{ systemd_dir }}/k3s-node.service.d/http_proxy.conf"
     owner: root
     group: root
     mode: '0755'

roles/raspberrypi/tasks/main.yml

@@ -17,21 +17,19 @@
   when:
     grep_cpuinfo_raspberrypi.rc == 0 or grep_device_tree_model_raspberrypi.rc == 0
 
-- name: Set detected_distribution to Raspbian
+- name: Set detected_distribution to Raspbian (ARM64 on Raspbian, Debian Buster/Bullseye/Bookworm)
-  set_fact:
-    detected_distribution: Raspbian
-  when: >
-    raspberry_pi|default(false) and
-    ( ansible_facts.lsb.id|default("") == "Raspbian" or
-      ansible_facts.lsb.description|default("") is match("[Rr]aspbian.*") )
-
-- name: Set detected_distribution to Raspbian (ARM64 on Debian Buster)
   set_fact:
     detected_distribution: Raspbian
+  vars:
+    allowed_descriptions:
+      - "[Rr]aspbian.*"
+      - "Debian.*buster"
+      - "Debian.*bullseye"
+      - "Debian.*bookworm"
   when:
     - ansible_facts.architecture is search("aarch64")
     - raspberry_pi|default(false)
-    - ansible_facts.lsb.description|default("") is match("Debian.*buster")
+    - ansible_facts.lsb.description|default("") is match(allowed_descriptions | join('|'))
 
 - name: Set detected_distribution_major_version
   set_fact:
@@ -39,14 +37,6 @@
   when:
     - detected_distribution | default("") == "Raspbian"
 
-- name: Set detected_distribution to Raspbian (ARM64 on Debian Bullseye)
-  set_fact:
-    detected_distribution: Raspbian
-  when:
-    - ansible_facts.architecture is search("aarch64")
-    - raspberry_pi|default(false)
-    - ansible_facts.lsb.description|default("") is match("Debian.*bullseye")
-
 - name: Execute OS related tasks on the Raspberry Pi - {{ action_ }}
   include_tasks: "{{ item }}"
   with_first_found:

roles/reset/tasks/main.yml

@@ -51,7 +51,9 @@
     name: "{{ item }}"
     state: absent
   with_items:
+    - "{{ systemd_dir }}/k3s.service.d/http_proxy.conf"
     - "{{ systemd_dir }}/k3s.service.d"
+    - "{{ systemd_dir }}/k3s-node.service.d/http_proxy.conf"
     - "{{ systemd_dir }}/k3s-node.service.d"
   when: proxy_env is defined