mirror of
https://github.com/techno-tim/k3s-ansible.git
synced 2026-10-23 04:12:03 +02:00
Marc Palacín
377687cbbe
* fix(k3s_server): skip k3s-init log collection when the destination is unset
The guard on the k3s-init diagnostics include used a boolean default for
the ANSIBLE_K3S_LOG_DIR lookup so that the when conditional would be a real
boolean. That is unnecessary: `log_destination | default('') != ''` is a
comparison and always evaluates to a bool, so ansible-core 2.19 never sees
a non-boolean conditional here.
The boolean default also defeats the guard. With ANSIBLE_K3S_LOG_DIR unset,
log_destination is the bool False, and `False != ''` is True in Python
because False == 0. The include therefore runs on every provisioning run,
executing the journalctl, systemctl, ip, ss, iptables, service_facts, ping
and wait_for diagnostics in fetch_k3s_init_logs.yml, then creating a
directory literally named "False" in the operator's working directory.
Use an empty-string default so the unset case renders "" and the guard
skips. CI did not catch this because .github/workflows/test.yml always
exports ANSIBLE_K3S_LOG_DIR.
Add a regression test that parses the role, renders the real log_destination
expression for both the unset and set cases, and asserts that no boolean
default has been reintroduced.
* chore(site): wrap the over-long kubeconfig fetch conditional
172 lines
7.1 KiB
YAML
172 lines
7.1 KiB
YAML
---
|
|
repos:
|
|
- repo: https://github.com/pre-commit/pre-commit-hooks
|
|
rev: v4.5.0
|
|
hooks:
|
|
- id: requirements-txt-fixer
|
|
- id: sort-simple-yaml
|
|
- id: detect-private-key
|
|
- id: check-merge-conflict
|
|
- id: end-of-file-fixer
|
|
- id: mixed-line-ending
|
|
- id: trailing-whitespace
|
|
args: [--markdown-linebreak-ext=md]
|
|
- repo: https://github.com/adrienverge/yamllint.git
|
|
rev: v1.33.0
|
|
hooks:
|
|
- id: yamllint
|
|
args: [-c=.yamllint]
|
|
- repo: https://github.com/ansible-community/ansible-lint.git
|
|
rev: v6.22.2
|
|
hooks:
|
|
- id: ansible-lint
|
|
additional_dependencies: [ansible-core==2.18.0]
|
|
language_version: python3.12
|
|
args: [--offline]
|
|
- repo: https://github.com/Lucas-C/pre-commit-hooks
|
|
rev: v1.5.4
|
|
hooks:
|
|
- id: remove-crlf
|
|
- id: remove-tabs
|
|
- repo: https://github.com/sirosen/texthooks
|
|
rev: 0.6.4
|
|
hooks:
|
|
- id: fix-smartquotes
|
|
- repo: local
|
|
hooks:
|
|
- id: shellcheck
|
|
name: shellcheck
|
|
entry: shellcheck
|
|
language: python
|
|
additional_dependencies: [shellcheck-py==0.11.0.1]
|
|
types: [shell]
|
|
- id: cleanup-runner-resources-test
|
|
name: cleanup runner resources test
|
|
entry: .github/scripts/test-cleanup-runner-resources.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^\.github/scripts/(cleanup-runner-resources|test-cleanup-runner-resources)\.sh$
|
|
- id: download-vagrant-boxes-test
|
|
name: Vagrant box download test
|
|
entry: .github/test-download-boxes.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^\.github/(download-boxes|test-download-boxes)\.sh$|^\.github/vagrant-boxes\.lock$
|
|
- id: prepare-vagrant-box-masters-test
|
|
name: Vagrant box master preparation test
|
|
entry: .github/scripts/test-prepare-vagrant-box-masters.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^\.github/scripts/(prepare-vagrant-box-masters|test-prepare-vagrant-box-masters)\.sh$
|
|
- id: k3s-server-bootstrap-test
|
|
name: K3s transient bootstrap test
|
|
entry: .github/scripts/test-k3s-server-bootstrap.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server/tasks/(main|join_master)\.yml$|^\.github/scripts/test-k3s-server-bootstrap\.sh$
|
|
- id: k3s-init-log-destination-test
|
|
name: K3s init log destination test
|
|
entry: .github/scripts/test-k3s-init-log-destination.py
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server/tasks/main\.yml$|^\.github/scripts/test-k3s-init-log-destination\.py$
|
|
- id: unique-hostname-precheck-test
|
|
name: Unique hostname precheck test
|
|
entry: .github/scripts/test-unique-hostname-precheck.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^site\.yml$|^\.github/scripts/test-unique-hostname-precheck\.sh$
|
|
- id: disable-swap-test
|
|
name: Disable swap test
|
|
entry: .github/scripts/test-disable-swap.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^roles/prereq/(tasks/main|defaults/main)\.yml$|^\.github/scripts/test-disable-swap\.sh$
|
|
- id: raspberrypi-detection-test
|
|
name: Raspberry Pi detection test
|
|
entry: .github/scripts/test-raspberrypi-detection.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^roles/raspberrypi/(tasks/main|defaults/main)\.yml$|^\.github/scripts/test-raspberrypi-detection\.sh$
|
|
- id: cilium-bgp-manifest-test
|
|
name: Cilium BGP manifest test
|
|
entry: python3 .github/scripts/test-cilium-bgp-manifest.py
|
|
language: python
|
|
additional_dependencies:
|
|
- Jinja2>=3.1
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server_post/templates/cilium\.crs\.j2$|^\.github/scripts/test-cilium-bgp-manifest\.py$
|
|
- id: cilium-envoy-toggle-test
|
|
name: Cilium Envoy toggle test
|
|
entry: python3 .github/scripts/test-cilium-envoy-toggle.py
|
|
language: python
|
|
additional_dependencies:
|
|
- Jinja2>=3.1
|
|
- PyYAML
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server_post/tasks/cilium\.yml$|^\.github/scripts/test-cilium-envoy-toggle\.py$
|
|
- id: kube-vip-manifest-test
|
|
name: kube-vip manifest test
|
|
entry: python3 .github/scripts/test-kube-vip-manifest.py
|
|
language: python
|
|
additional_dependencies:
|
|
- Jinja2>=3.1
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server/templates/vip\.yaml\.j2$|^\.github/scripts/test-kube-vip-manifest\.py$
|
|
- id: metallb-remote-read-test
|
|
name: MetalLB remote read test
|
|
entry: .github/scripts/test-metallb-remote-read.sh
|
|
language: system
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server/tasks/metallb\.yml$|^\.github/scripts/test-metallb-remote-read\.sh$
|
|
- id: metallb-interfaces-test
|
|
name: MetalLB interfaces test
|
|
entry: python3 .github/scripts/test-metallb-interfaces.py
|
|
language: python
|
|
additional_dependencies:
|
|
- Jinja2>=3.1
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server_post/templates/metallb\.crs\.j2$|^\.github/scripts/test-metallb-interfaces\.py$
|
|
- id: metallb-namespace-test
|
|
name: MetalLB namespace test
|
|
entry: python3 .github/scripts/test-metallb-namespace.py
|
|
language: python
|
|
additional_dependencies:
|
|
- PyYAML
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server_post/tasks/metallb\.yml$|^\.github/scripts/test-metallb-namespace\.py$
|
|
- id: metallb-deploy-condition-test
|
|
name: MetalLB deploy condition test
|
|
entry: python3 .github/scripts/test-metallb-deploy-condition.py
|
|
language: python
|
|
additional_dependencies:
|
|
- Jinja2>=3.1
|
|
- PyYAML
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server/tasks/main\.yml$|^roles/k3s_server_post/tasks/main\.yml$|^\.github/scripts/test-metallb-deploy-condition\.py$ # noqa yaml[line-length]
|
|
- id: kube-vip-deploy-condition-test
|
|
name: kube-vip deploy condition test
|
|
entry: python3 .github/scripts/test-kube-vip-deploy-condition.py
|
|
language: python
|
|
additional_dependencies:
|
|
- Jinja2>=3.1
|
|
- PyYAML
|
|
pass_filenames: false
|
|
files: ^roles/k3s_server/tasks/main\.yml$|^\.github/scripts/test-kube-vip-deploy-condition\.py$ # noqa yaml[line-length]
|
|
- id: default-interface-test
|
|
name: default interface test
|
|
entry: python3 .github/scripts/test-default-interface.py
|
|
language: python
|
|
additional_dependencies:
|
|
- Jinja2>=3.1
|
|
pass_filenames: false
|
|
files: ^inventory/sample/group_vars/all\.yml$|^\.github/scripts/test-default-interface\.py$
|
|
- id: verify-nginx-assert-test
|
|
name: verify nginx assert test
|
|
entry: python3 .github/scripts/test-verify-nginx-assert.py
|
|
language: python
|
|
additional_dependencies:
|
|
- PyYAML
|
|
pass_filenames: false
|
|
files: ^molecule/resources/verify_from_outside/tasks/test/deploy-example\.yml$|^\.github/scripts/test-verify-nginx-assert\.py$ # noqa yaml[line-length]
|